https://bugzilla.redhat.com/show_bug.cgi?id=2346284 --- Comment #5 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Davide, my apologies for the delay, I had a lot of other things going on. I really like the changes you did. > Name: hexcurse Just for the record, I am saying out loud that I am not sure if we should name the package hexcurse or hexcurse-ng but since it provides /usr/bin/hexcurse I think we can keep the name hexcurse. > Version: 1.60 Is there a reason why you packaged 1.60 instead of the latest 1.70.0? If possible, we always try to package the latest version. Also, looking at the tag history https://github.com/prso/hexcurse-ng/tags the version would be 1.60.0, not 1.60 > BuildRequires: autoconf The autoconf dependency must be really important because you listed it twice ;-) > Issues: > ======= > - The License field must be a valid SPDX expression. > Note: Not a valid SPDX expression 'GPLv2+'. It seems that you are using > the old Fedora license abbreviations. Try `license-fedora2spdx' for > converting it to SPDX. > See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 The fedora-review tool complains about this. Try using the license-fedora2spdx tool, it will tell you the correct licence name. We also have some errors from rpmlint: > hexcurse.x86_64: W: spurious-executable-perm /usr/share/doc/hexcurse/AUTHORS > hexcurse.x86_64: W: spurious-executable-perm /usr/share/doc/hexcurse/ChangeLog > hexcurse.x86_64: W: spurious-executable-perm /usr/share/doc/hexcurse/NEWS > hexcurse.x86_64: W: spurious-executable-perm /usr/share/doc/hexcurse/README.md For some reason, these files have an executable bit. When I install your package and do this: $ ls -l /usr/share/doc/hexcurse/README.md -rwxr-xr-x. 1 root root 2643 Feb 13 01:00 /usr/share/doc/hexcurse/README.md It is there. However, I have no idea where it came from because the permissions in the upstream tarball are correct. > hexcurse.src: W: no-url-tag The spec file should have an URL attribute pointing to the upstream project: URL: https://github.com/prso/hexcurse-ng > hexcurse.x86_64: W: incoherent-version-in-changelog 1.60 ['1.60-1.fc43', '1.60-1'] The version number in the changelog must contain also the release number. In your case 1.60-1 Otherwise, the package builds and installs correctly. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2346284 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346284%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
