[Bug 2352883] Review Request: plutosvg - Tiny SVG rendering library in C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2352883



--- Comment #14 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Benson Muite from comment #13)

> b) In the %check section, please change
> %{_vpath_builddir}/examples/camera2png
> %{_vpath_builddir}/examples/svg2png camera.svg camera.png
> to
> %{_vpath_builddir}/examples/plutovgcamera2png
> %{_vpath_builddir}/examples/plutovgsvg2png camera.svg camera.png
> c) Approved. Please fix (b) before import.

This is not correct, the binaries are used from the build directory, and in
there they are not renamed yet. In fact the package builds fine.

> d) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2354812 would be
> appreciated.

Sure.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2352883

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352883%23c14

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux