https://bugzilla.redhat.com/show_bug.cgi?id=2353001 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Ah, I see now that I mis-interpreted something the first time round, by looking at the git diff wrongly. > # Manually created patch for downstream crate metadata changes This line is usually kept for Rust packages. Either way, you need to document the patch in some way, ideally by adding links to upstream PRs (or commits) to bump the two dependencies you adjusted. Other than that, looks good to me, thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353001 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353001%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
