https://bugzilla.redhat.com/show_bug.cgi?id=2354830 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #15 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- LGTM. I can't spot any big issues so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: No need for a separate -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4717 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: The source package does not include license text(s) as a separate file from upstream. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged (2.6.3). [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources weren't verified with gpgverify first in %prep (upstream does not publish signatures). [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). ^^^ This is fine with autorelease and autochangelog macros. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: novelwriter-2.6.3-1.fc43.noarch.rpm novelwriter-doc-2.6.3-1.fc43.noarch.rpm novelwriter-2.6.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7wymrzoy')] checks: 32, packages: 3 novelwriter.noarch: E: spelling-error ('organisation', '%description -l en_US organisation -> organization, organist, sanitation') novelwriter.noarch: E: spelling-error ('synchronisation', '%description -l en_US synchronisation -> synchronization, synchronicity') novelwriter.src: E: spelling-error ('organisation', '%description -l en_US organisation -> organization, organist, sanitation') novelwriter.src: E: spelling-error ('synchronisation', '%description -l en_US synchronisation -> synchronization, synchronicity') novelwriter-doc.noarch: E: spelling-error ('javascript', '%description -l en_US javascript -> java script, java-script, JavaScript') ^^^ False positives (US vs. British english) novelwriter.noarch: W: no-manual-page-for-binary novelwriter ^^^ Well, can be ignored. We can't do much here. novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/i18n/project_en_US.json /usr/lib/python3.13/site-packages/novelwriter/assets/i18n/project_en_GB.json novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_light/nw_deco-h0.svg /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_dark/nw_deco-h0.svg novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_light/nw_deco-noveltree-more.svg /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_dark/nw_deco-noveltree-more.svg 3 packages and 0 specfiles checked; 5 errors, 4 warnings, 11 filtered, 5 badness; has taken 1.6 s ^^^ Can be ignored. Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 novelwriter-doc.noarch: E: spelling-error ('javascript', '%description -l en_US javascript -> java script, java-script, JavaScript') novelwriter.noarch: E: spelling-error ('organisation', '%description -l en_US organisation -> organization, organist, sanitation') novelwriter.noarch: E: spelling-error ('synchronisation', '%description -l en_US synchronisation -> synchronization, synchronicity') novelwriter.noarch: W: no-manual-page-for-binary novelwriter novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/i18n/project_en_US.json /usr/lib/python3.13/site-packages/novelwriter/assets/i18n/project_en_GB.json novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_light/nw_deco-h0.svg /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_dark/nw_deco-h0.svg novelwriter.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_light/nw_deco-noveltree-more.svg /usr/lib/python3.13/site-packages/novelwriter/assets/icons/typicons_dark/nw_deco-noveltree-more.svg 2 packages and 0 specfiles checked; 3 errors, 4 warnings, 7 filtered, 3 badness; has taken 0.5 s Source checksums ---------------- https://github.com/vkbo/novelwriter/archive/v2.6.3/novelwriter-2.6.3.tar.gz : CHECKSUM(SHA256) this package : 8d18acf0069852c2598e73c3b76b4a8cf1d1c96d485d5165ff8cf3337ec7f920 CHECKSUM(SHA256) upstream package : 8d18acf0069852c2598e73c3b76b4a8cf1d1c96d485d5165ff8cf3337ec7f920 Requires -------- novelwriter (rpmlib, GLIBC filtered): /usr/bin/python3 hicolor-icon-theme python(abi) python3.13dist(pyenchant) python3.13dist(pyqt5) novelwriter-doc (rpmlib, GLIBC filtered): Provides -------- novelwriter: application() application(novelwriter.desktop) metainfo() metainfo(novelwriter.appdata.xml) mimehandler(application/x-novelwriter-project) novelwriter python3.13dist(novelwriter) python3dist(novelwriter) novelwriter-doc: novelwriter-doc Diff spec file in url and in SRPM --------------------------------- --- /home/petro/rpmbuild/SPECS/2354830-novelwriter/srpm/novelwriter.spec 2025-03-28 12:07:06.820158605 +0100 +++ /home/petro/rpmbuild/SPECS/2354830-novelwriter/srpm-unpacked/novelwriter.spec 2025-03-26 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: novelwriter Version: 2.6.3 @@ -110,3 +120,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Mar 26 2025 John Doe <packager@xxxxxxxxxxx> - 2.6.3-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2354830 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: R, Perl, Java, fonts, C/C++, Ocaml, PHP, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH THis package is ================ === APPROVED === ================ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354830 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354830%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
