https://bugzilla.redhat.com/show_bug.cgi?id=2352963 jandrlik <jandrlik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #13 from jandrlik <jandrlik@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/java/java-25-openjdk/java-25-openjdk/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/sdp/sdp.conf.template [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36540 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Reviewer note: IcedTea [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer note: generated sources [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong, but is promised to be looked at later. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. Java: [x]: Packages are noarch unless they use JNI Note: java-25-openjdk subpackage is not noarch. Please verify manually Reviewer note: uses JNI [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2352963 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352963%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
