https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxwell@xxxxxxx --- Comment #2 from Maxwell G <maxwell@xxxxxxx> --- Some notes (as a member of the Go SIG and author of go-vendor-tools) * LicenseRef-scancode-public-domain-disclaimer should be changed to LicenseRef-Fedora-Public-Domain. LicenseRef-scancode-public-domain-disclaimer is not a Fedora-approved license. You will need to depend on go-vendor-tools >= 0.7.0 (currently only available in rawhide, stable updated in progress) that performs this normalization automatically or add a manual license override in the config file. * CC0-1.0 is not allowed for code in Fedora anymore. HINT: Inspect the go_vendor_license report and figure out which library this license applies to. If it is available as a golang-*-devel package, you can probably cite the "Existing uses of CC0-1.0 on code files in Fedora packages prior to 2022-08-01" exception as a specfile comment. * This does not currently pass %gobuild_ldflags (the Go linker flags) to the Makefile. You can look at how moby-engine does this (and the source code comments in https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-compilers-golang) or just use the %gobuild macro which is probably a lot easier. * You should use the Fedora compiler flags and disable static linking instead of turning off debug_package. * The scancode-toolkit package is broken on s390x on Fedora releases other than rawhide. Working on fixing this. * Note that the go-vendor-tools project is still in beta and mainly intended for testing by members of the Go SIG. See https://fedora.gitlab.io/sigs/go/go-vendor-tools/#stability. Work towards a final release is making good progress, though! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
