[Bug 2353412] Review Request: libgenht - Simple generic hash table implementation in C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2353412



--- Comment #6 from Steve <skrochen@xxxxxxxxxx> ---
Artur, thanks for the feedback

>> Patch0:         00-fix-makefile.patch
>> [...]
>> sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile
>you're already patching the Makefile, why use sed?
>Why not add this change to the patch?
The patch isn't mine, it comes from my upstream, who is a Debian Dude :)

>> %build
>> %set_build_flags
>Calling %set_build_flags manually is not needed since Fedora 36.
Done

>Also, looking at the build log:
>> cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h
>>[...]
>It might be good to patch the Makefile (or alter the make call) to use "cp -p" in order to preserve file timestamps.
Done, also in the spec file


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2353412

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353412%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux