https://bugzilla.redhat.com/show_bug.cgi?id=2353412 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Patch0: 00-fix-makefile.patch > [...] > sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile You're already patching the Makefile, why use sed? Why not add this change to the patch? > %build > %set_build_flags Calling %set_build_flags manually is not needed since Fedora 36. Also, looking at the build log: > cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h > cp `pwd`/siphash24.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/siphash24.h > cp `pwd`/ht.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.h > cp `pwd`/ht.c /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.c It might be good to patch the Makefile (or alter the make call) to use "cp -p" in order to preserve file timestamps. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353412%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
