https://bugzilla.redhat.com/show_bug.cgi?id=2353299 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two comments: - The "doctests" are broken indeed, but they're not *really* doctests ... not sure how upstream doesn't notice that running "cargo test" fails, but the code snippet that's broken is actually the one from the README.md that's include_str!d as a docstring. - Thanks for filing a PR to include license files upstream - let's see if upstream reacts in a timely fashion. If not, it's probably acceptable to say "these are the standardized Apache-2.0 and MIT license texts, this is the best we can do here". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2353299 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353299%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
