https://bugzilla.redhat.com/show_bug.cgi?id=2352883 --- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #2) > > rm -fr %{_vpath_builddir}/examples/*.p > > Please change that to rm -rv or rm -r. Using -f makes it succeed even if > there are no files to delete. > > > %files samples > > %{_bindir}/* > > What's the reason for the wildcard? > Are there too many to list? > Does the list change between releases? Just a habit for the "rm -f". I changed the installation of the samples by patching the meson.build file, it's something that came out as part of the plutovg review. Now the samples are installed as part of the meson install command, which simplifies the SPEC file and makes sure that the rpath is stripped during install. I've also changed it to a list. > > -D tests=enabled > > While the option is there: > https://github.com/sammycage/plutosvg/blob/master/meson_options.txt#L2 > it doesn't seem to be used anywhere, so there's little point in enabling it. I prefer to left it enabled so I won't forget to re-enable it in the future. I've added a note that is currently a no-op and added the execution of some sample binaries that do not require extra files (as extra from the main plutosvg tarball) as a test. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2352883 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352883%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
