https://bugzilla.redhat.com/show_bug.cgi?id=2352880 --- Comment #6 from Simone Caronni <negativo17@xxxxxxxxx> --- > a) Please list the binary smiley in %{_bindir} rather than globbing, it may > cause collisions if it changes Done. > b) Additional licenses seem to be used: > Freetype Project License > ------------------------ > plutovg-1.0.0-build/plutovg-1.0.0/source/FTL.TXT > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-math.c > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-math.h > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-raster.c > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-raster.h > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-stroker.c > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-stroker.h > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-ft-types.h > > MIT License > ----------- > plutovg-1.0.0-build/plutovg-1.0.0/LICENSE > plutovg-1.0.0-build/plutovg-1.0.0/include/plutovg.h > > MIT License and/or The Unlicense > -------------------------------- > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-stb-image-write.h > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-stb-image.h > plutovg-1.0.0-build/plutovg-1.0.0/source/plutovg-stb-truetype.h Fixed, changed to MIT AND FTL, as unlicense is an optional. > c) A newer version of stb is in Fedora: > https://src.fedoraproject.org/rpms/stb > If the one in Fedora cannot be used, may wish to ask upstream to update to > the newer version and also indicates the bundled stb as a provides in the > spec file. Done, patched to use system stb. > d) Please remove the rpath or perhaps do not package smiley the example > application Done, I added the install of the samples to the meson.build file, that takes care of stripping the path on install. It also simplifies the SPEC file. > e) Builds on all architectures > https://koji.fedoraproject.org/koji/taskinfo?taskID=130395014 This is already fine? > f) As a smoke test consider running the smiley binary Good idea. I added it along with some comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2352880 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352880%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
