https://bugzilla.redhat.com/show_bug.cgi?id=2334976 --- Comment #13 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks. I suspect that these may be legitimate. Normally these %{_datadir}/gir-1.0/CambalachePrivate-3.0.gir %{_datadir}/gir-1.0/CambalachePrivate-4.0.gir %{_datadir}/gir-1.0/CmbCatalogUtils-3.0.gir %{_datadir}/gir-1.0/CmbCatalogUtils-4.0.gir and at least some of the Requires on -devel packages would belong in a cambalache-devel package, with .typelib files used for runtime introspection from dynamic languages. On the other hand, since this is a developer tool, all bets are off – it really might need things that would normally go in a -devel package at runtime. It’s worth having a second look at this, but in the end, you know the package better than I do, and I have only so much time to study it. I have to assume you’ve made a reasonable choice. If including these in the base package does turn out to be an error, then it’s one that causes very little harm. OK. # Needed for ownership of %%{_datadir}/gir-1.0 (Also, the comment contains a minor typo, ownsership for ownership.) Done Therefore, overall, I think the License should be: License: LGPL-2.1-only AND GPL-2.0-only AND GPL-2.0-or-later Done So it *looks* like these are sufficient, in addition to the Requires already present: Requires: libadwaita Requires: python3-gobject-base Requires: python3-lxml Done - At ~1.3 MB, the contents of /usr/share/cambalache are large enough that you might consider separating them into a noarch -data subpackage upon which the base package depends, so that the noarch package can be shared across architectures (saving storage on Fedora mirrors). However, this directory is still small enough that I wouldn’t consider separating it to be *necessary*. Done - Could you please add a comment to the spec file briefly summarizing the reason for packaging a post-release snaphsot? Done Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=130402822 spec: https://fed500.fedorapeople.org/cambalache.spec srpm: https://fed500.fedorapeople.org/cambalache-0.94.1^20250115git31b93cef-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2334976 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334976%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
