https://bugzilla.redhat.com/show_bug.cgi?id=2344119 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- A few minor things: 1. I see you've submitted the bindings for gst-check too, do you think it would make sense to wait until they are in Fedora so tests can be enabled here? 2. There's a newer version out (0.13.4 vs. 0.13.5), it would be great to get the latest version in. 3. The packaging matches other GStreamer plugins almost 100%, so I'm wondering if you intentionally dropped the "Provides" for the actual upstream project name (gst-plugin-ndi) or if they're just accidentally missing? Other than that, the package looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2344119 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202344119%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
