https://bugzilla.redhat.com/show_bug.cgi?id=2349303 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I haven’t read through the whole package or the whole review, but just a couple of contributions: (In reply to Tom.Rix from comment #5) > Why isn't this just ? > > License: Apache-2.0 > > I do not think it is necessary include > > %license bindings/python/LICENSE.dependencies > > As you are not bundling these packages Rust dependencies are statically linked, so their licenses (based on the output of %{cargo_license_summary} during a build) MUST be included in the License tags of the binary RPMs: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_license_tags > python3-safetensors+numpy: > python3-safetensors+torch: > > These I think are overkill, reduce to just python3-safetensors, even if it > means > needed to manually add > > Requires: python3dist(numby) > Requires: python3dist(torch) These extras matapackages are the right way to package Python extras: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_handling_extras Simply adding the dependencies as extra Requires has some issues: - Things that don’t require the optional functionality associated with the extra would then bring in unnecessary dependencies – and python3-torch is HUGE. - This would *not* be able to satisfy Python dependencies that actually require the extras, like python3dist(safetensors[numpy]). Only the metapackages furnish the appropriate Provides. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2349303 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202349303%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
