https://bugzilla.redhat.com/show_bug.cgi?id=2349044 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to git.vmg from comment #3) > Hello, > > I need some help with missing dependencies. Should I package them > individually, or is there some other way? Yes, you should package them individually. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_vendored_dependencies. This could end up being a reasonably large number of packages, but that’s the nature of a relatively complex application like this. In some cases, the dependency may already be in Fedora, but with a version that is older or newer than what upstream wants. For example, the package wants (crate(dirs/default) >= 6.0.0 with crate(dirs/default) < 7.0.0~), and we have rust-dirs 5.0.1. See bug 2337230. The options would be, (1) determine by a combination of reading diffs/changelogs and practical testing that you can safely patch the version range, and do so, or (2) ask the maintainer to update, and help coordinate it if you are able. A SemVer-breaking update like that needs to be coordinated with dependent packages (possibly updating them or patching them to allow the new version), or a compat package for the old version needs to be introduced if that’s not practical. Another example is url: upstream wants 2.5.4, but 2.5.3 switched to ICU4X as the Unicode backend, which means we have to package dozens of new crates as dependencies. This is desirable, but still a work in progress, so this is a case where you’ll have to just loosen the version bound to allow 2.5.2. > > Project's GitHub Repository: https://github.com/raphamorim/rio > Copr: https://copr.fedorainfracloud.org/coprs/vedantmgoyal/rio/ > > You can check the repository for reference. When I run `rust2rpm`, I get a > license file error, and I'm unsure how to resolve it. Since I don’t know the > exact issue, I’m not sure how to communicate it to the maintainer. For now, > I’ve added the `--ignore-missing-license-files` flag to generate a spec > file, but I’m still unable to build it successfully due to the dependency > error. I opened an upstream PR to fix missing license files in future releases: https://github.com/raphamorim/rio/pull/1003 Until that’s merged and released, you can use something like this in rust2rpm.toml to patch in the license file: [[package.extra-sources]] number = 10 file = "https://github.com/raphamorim/rio/raw/refs/tags/v%{version}/LICENSE"; comments = [ """\ Missing MIT license text; see \ “Add missing LICENSE files to several workspace crates,” \ https://github.com/raphamorim/rio/pull/1003\ """, ] [scripts.prep] pre = [ "cp -p '%{SOURCE10}' .", ] Then, you’ll have to add this to "%files devel": %license %{crate_instdir}/LICENSE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2349044 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202349044%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
