https://bugzilla.redhat.com/show_bug.cgi?id=2348709 --- Comment #6 from qde@xxxxxxxx --- (In reply to Artur Frenszek-Iwicki from comment #5) > > %cmake -DNO_DOCS=1 > Why not? This refers to the HTML documentation that is published at bpfilter.io. It would pull in various dependencies and not be included in the final package. > > %files > > [...] > > /usr/lib/systemd/system/bpfilter.service > This should probably use %{_unitdir}. > > Other minor issues: > 1. Missing "BuildRequires: make". Currently it is pulled transitively by > cmake, but that may change. > 2. Missing license file. Please add "%license COPYING" to %files. Done! Spec URL: https://naccyde.fedorapeople.org/bpfilter.spec SRPM URL: https://naccyde.fedorapeople.org/bpfilter-0.2.1-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2348709 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202348709%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
