[games-sig][Bug 2379721] Review Request: openmw - OpenMW is an open-source game engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2379721



--- Comment #21 from Claire Robsahm <inquiries@xxxxxxxxxxx> ---
(In reply to Neal Gompa from comment #20)
> Spec review notes:
> 
> > Provides:       bundled(MysticCards)
> > Provides:       bundled(DemonicLetters)
> 
> This should be bundled(fonts(<fontname>)), since these fonts are in TTF/OTF
> form.

Fixed.

> > %patch 0 -p1
> > %patch 1 -p1
> 
> This can be replaced with "%autopatch -p1".

Only one patch is necessary as I symlink the font now.

> > %build
> > # Now, we build OpenMW.
> > %cmake -G Ninja \
> >     -DBUILD_OPENMW_TESTS:BOOL=ON \
> >     -DBULLET_STATIC:BOOL=ON \
> >     -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON \
> >     -DFETCHCONTENT_SOURCE_DIR_BULLET:PATH=%{_builddir}/bullet \
> >     -DFETCHCONTENT_SOURCE_DIR_OSG:PATH:PATH=%{_builddir}/osg \
> >     -DFETCHCONTENT_SOURCE_DIR_RECASTNAVIGATION:PATH=%{_builddir}/recastnavigation \
> >     -DGLOBAL_DATA_PATH:PATH=%{_datadir} \
> >     -DOPENMW_USE_SYSTEM_BULLET:BOOL=OFF \
> >     -DOPENMW_USE_SYSTEM_GOOGLETEST:BOOL=ON \
> >     -DOPENMW_USE_SYSTEM_OSG:BOOL=OFF \
> >     -DOSG_STATIC:BOOL=ON
> 
> Unless you plan to ship this in EPEL 8/9, it would be good to move the
> %cmake invocation to the %conf section.
> 
> Cf.
> https://rpm-software-management.github.io/rpm/manual/spec.html#conf-since-
> rpm--418

I was unaware. Fixed.

SPEC URL:
https://git.chapien.net/chapien/openmw-rpm/raw/branch/main/openmw.spec
SRPM URL:
https://git.chapien.net/chapien/openmw-rpm/raw/branch/main/SRPMS/openmw-0.49.0-1.fc42.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2379721

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379721%23c21

-- 
_______________________________________________
Fedora Games SIG mailing list -- games@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to games-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/games@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Music]     [Fedora Extras]     [Kernel]     [Fedora Desktop]     [Fedora Directory]     [PAM]     [CentOS]     [Gimp]     [Yosemite News]     [Yosemite Camping]

  Powered by Linux