https://bugzilla.redhat.com/show_bug.cgi?id=2379721 --- Comment #12 from Alexander Lent <lx@xxxxxxxxxxxxxx> --- (In reply to Claire Robsahm from comment #11) > (In reply to Alexander Lent from comment #10) > > I took a quick look at the spec file - it's quite good overall - and wanted > > to note the bundling policy: > > https://docs.fedoraproject.org/en-US/fesco/Bundled_Software_policy/ > > > > To summarize, each bundled package needs to have a `Provides: > > bundled(package_name) = package_version`, so that its existence and > > potential security vulnerabilities can be identified from package metadata. > > > > Also, each bundled package should be justified as to why it meets the policy > > and can't be shipped separately in Fedora. > > > > As an example, looking at Repology, it seems like the recastnavigation > > package could be included in Fedora independently. > > Hey, thanks for the feedback! Thank you, in turn, for the clarification. > > I think I justified adequately why I am bundling Bullet and OpenSceneGraph; > both are provided by Fedora, but Bullet needs to be double precision and > there's a fork of OSG provided by OpenMW that provides superior performance. > I believe both of those are good explanations. I saw the justifications, and I agree; we have a similar situation with the OpenVINO toolkit for AI/ML packaging a custom version of libraries already otherwise packaged. > > As for Recast, I'm not sure why we don't package it. Godot also requires it, > but the Fedora godot package statically links it. The CMAKE for openMW by > default statically links recastnavigation rather than using the system > recast; this was notable to me, as everything else was the reverse (i.e., I > had to explicitly use static/non-system OSG and Bullet). To me, that > indicates that recast might be better off being statically linked. However, > I can ask upstream about their logic with regards to recast. As for the > other two, I'll add in the Provides: bundled() in my next update; As I said, > I believe I've adequately explained why I am statically linking those two. Reading the godot package, it looks like recastnavigation could be unbundled, but there were no other users at the time. If you can get openmw upstream to allow using a system library, we could unbundle it for both; it might be worth throwing a comment about that into the specfile. (If I was a CMake wizard, I'd try patching it in myself, but alas, I am but a beginner and all my CMake patches are terrible hacks.) -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2379721 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379721%23c12 -- _______________________________________________ Fedora Games SIG mailing list -- games@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to games-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/games@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
