Re: How to override RUSTFLAGS in .spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 19, 2025 at 12:02 AM Fabio Valentini <decathorpe@xxxxxxxxx> wrote:
>
> On Mon, Aug 18, 2025 at 3:53 PM Ming Lei <ming.lei@xxxxxxxxxx> wrote:
> >
> > Hello,
> >
> > I am trying to add `export RUSTFLAGS="${RUSTFLAGS}
> > --cfg=io_uring_skip_arch_check"`
> > during %build, however looks it doesn't work, please see the following log[1]:
> >
> > + export 'RUSTFLAGS=-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1
> > -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes
> > --cap-lints=warn --cfg=io_uring_skip_arch_check'
> > + RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1
> > -Cstrip=none -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes
> > --cap-lints=warn --cfg=io_uring_skip_arch_check'
> > + /usr/bin/env CARGO_HOME=.cargo RUSTC_BOOTSTRAP=1
> > 'RUSTFLAGS=-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none
> > -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes
> > --cap-lints=warn' /usr/bin/cargo build -j2 -Z avoid-dev-deps --profile
> > rpm
> >
> > [1] https://kojipkgs.fedoraproject.org//work/tasks/2169/136202169/build.log
> >
> > `io-uring` crate needs to skip arch check, otherwise it is easy to
> > trigger failure because of missing definition.
> >
> > Can anyone provide one hint about how to override ${RUSTFLAGS} in .spec?
>
> Skipping the arch check is the completely wrong thing to do here.
> It would get you past the initial bail, but likely just cause other
> issues later - and potentially worse ones.
>
> Instead, you probably need to force regeneration of the io-uring Rust
> bindings to make sure they're up-to-date and match the host
> architecture.

That can't work. io-uring often takes a very new kernel UAPI definition, which
may not be provided via kernel-devel in the system for building the crate.

The check shouldn't be so strict, because kernel can handle it correctly when
calling API with unknown parameters.

Thanks,
Ming

-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux