Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote:
>> Let me also mention the case where we have to clean sources (proprietary
>> material) before committing to the look-aside cache. We should document
>> how to do so in spec.
>> Ideally, one could:
>> - get original sources
>> - check upstream's signature
>> - apply the checked-in clean script (which creates a tarball)
>> - check that the results matches the look-aside hash in "sources".
> This takes us down a slight tangent, but I wonder whether it actually
> makes sense to have every developer write their own "cleaning" script ?
> Is there scope for standardizing on the repack process using 'fedpkg'
> tools perhaps ?
> It feels like it ought to be possible to define a standard repack process
> that works from a text file that simply contains a list of filename globs
> to purge from a source archive. That gives us a declarative description
> of how the downstream tarball will differ from the upstream tarball,
> instead of an imperative description via countless custom shell scripts.
Just removing some files is often not enough as they are
referenced in Makefiles, etc., so one would end up with a
declarative description that has the complexity of a shell
script.
But there is certainly some charm in having one (1) shell
script that parses the spec's Version, etc. fields, down-
loads whatever needs to be downloaded to a temporary direc-
tory, repacks that to %{sourcex} and cleans up the temporary
directory, with custom options to point to local Git reposi-
tories, caches, etc.
Tim
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
