Re: %pyproject_buildrequires -t/-e and %tox without a suitable tox configuration will error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13. 03. 25 19:39, Tomasz Torcz wrote:
On Thu, Mar 13, 2025 at 06:55:57PM +0100, Miro Hrončok wrote:
On 13. 03. 25 18:50, Milan Crha wrote:
On Wed, 2025-03-12 at 00:11 +0100, Miro Hrončok via devel-announce
wrote:
This change will land to rawhide first and later to all stable
releases as well.

However, if people fight me on this, I am willing to reconsider. All
affected packagers maintainers were bcced both a month ago and now.

   FTR, I am one of the maintainers bcced, and I have no idea what any of
the stuff in the original message mean.  I'd need to find some time to
reasearch what the tox is, and how it relates to my package.
   Having said that, I am not opposing the change.  I just do not
understand it at all. It is OK to do it in Rawhide, but let's leave F40-42
alone.
tl;dr if you don't know what tox is and your package is affected: don't use %pyproject_buildrequires -t/-e or %tox.

If you remove the -t/-e flag from %pyproject_buildrequires (and remove the %tox call if it exists), it will do the same thing as before (nothing) except it will not give a false sense of tests.

Here you go:
https://src.fedoraproject.org/rpms/python-simple-pid/pull-request/1

I can certainly make it so that f40-f42 is unaffected by the change, but I strongly believe that it is not necessary. (But I hear you and will yield if yours opinion is the majority.) The most "unsafe" thing is running %tox withotu a tox config -- as a compromise, I can only make that part hard error on f40-f42.

--
Miro Hrončok
--
Phone: +420777974800
Fedora Matrix: mhroncok

--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux