Hi, Dear maintainers
I met a "Segmentation fault" error of pahole. It happened when I
passed an ELF file without .symtab section.
Maybe I passed an unsupport file, but I think it should not segfault,
maybe a warnning or error message is better.
Here is the detailed info:
Pahole version:
# pahole --version
v1.29
Reproduce Command:
root@intel-x86-64:/~# pahole --btf_features=default -J
/boot/vmlinux-6.12.40-yocto-standard
pahole[599]: segfault at 8 ip 00007f7c92d819e2 sp 00007f7c799febe0 error
6 in libdwarves.so.1.0.0[189e2,7f7c92d72000+1c000] likely on CPU 0 (core
0, socket 0)
Code: 74 19 ff ff 48 39 dd 75 ef 4c 89 ef e8 67 19 ff ff 49 8b 7c 24 18
e8 8d 13 ff ff 49 8b 14 24 49 8b 44 24 08 4c 89 e7 45 31 e4 <48> 89 42
08 48 89 10 e8 42 19 ff ff e9 30 ff ff ff e8 58 0a ff ff
Segmentation fault (core dumped)
root@intel-x86-64:~# file /boot/vmlinux-6.12.40-yocto-standard
/boot/vmlinux-6.12.40-yocto-standard: ELF 64-bit LSB executable, x86-64,
version 1 (SYSV), statically linked,
BuildID[sha1]=1e73fe48101f07b9d991dc045ab9f9672a0feac0, stripped
root@intel-x86-64:/usr/bin# readelf -S
/boot/vmlinux-6.12.40-yocto-standard | grep .symtab
[ 4] __ksymtab PROGBITS ffffffff82c11e00 01e11e00
[ 5] __ksymtab_gpl PROGBITS ffffffff82c24730 01e24730
[ 6] __ksymtab_strings PROGBITS ffffffff82c397f0 01e397f0
(gdb) bt
#0 elf_functions__new (elf=<optimized out>) at
/usr/src/debug/pahole/1.29/btf_encoder.c:196
#1 0x00007ffff7f92a7d in btf_encoder__elf_functions
(encoder=encoder@entry=0x7fffd8008dc0) at
/usr/src/debug/pahole/1.29/btf_encoder.c:1374
#2 0x00007ffff7f94489 in btf_encoder__new (cu=cu@entry=0x7fffd8001e50,
detached_filename=<optimized out>, warning: could not convert 'btf' from
the host encoding (ANSI_X3.4-1968) to UTF-32.
This normally should not happen, please file a bug report.
base_btf=0x0,
verbose=<optimized out>, conf_load=conf_load@entry=0x555555565280
<conf_load>) at /usr/src/debug/pahole/1.29/btf_encoder.c:2431
#3 0x000055555555db49 in pahole_stealer__btf_encode (cu=0x7fffd8001e50,
conf_load=0x555555565280 <conf_load>)
at /usr/src/debug/pahole/1.29/pahole.c:3126
#4 pahole_stealer (cu=0x7fffd8001e50, conf_load=0x555555565280
<conf_load>) at /usr/src/debug/pahole/1.29/pahole.c:3187
#5 0x00007ffff7f9d023 in cus__steal_now (cus=<optimized out>,
cu=<optimized out>, conf=<optimized out>)
at /usr/src/debug/pahole/1.29/dwarf_loader.c:3266
#6 dwarf_loader__worker_thread (arg=0x7fffffffe700) at
/usr/src/debug/pahole/1.29/dwarf_loader.c:3672
#7 0x00007ffff7dbe722 in start_thread (arg=<optimized out>) at
pthread_create.c:448
#8 0x00007ffff7e314fc in __GI___clone3 () at
../sysdeps/unix/sysv/linux/x86_64/clone3.S:78
(gdb)
Command "pahole --btf_features=default -J
/boot/.debug/vmlinux-6.12.40-yocto-standard " works well since
/boot/.debug/vmlinux-6.12.40-yocto-standard has .symtab section.
root@intel-x86-64:/usr/bin#
file /boot/.debug/vmlinux-6.12.40-yocto-standard
/boot/.debug/vmlinux-6.12.40-yocto-standard: ELF 64-bit LSB executable,
x86-64, version 1 (SYSV), statically linked,
BuildID[sha1]=1e73fe48101f07b9d991dc045ab9f9672a0feac0, with debug_info,
not stripped
root@intel-x86-64:/usr/bin# readelf -S
/boot/.debug/vmlinux-6.12.40-yocto-standard | grep .symtab
[ 4] __ksymtab NOBITS ffffffff82c11e00 00001000
[ 5] __ksymtab_gpl NOBITS ffffffff82c24730 00001000
[ 6] __ksymtab_strings NOBITS ffffffff82c397f0 00001000
[49] .symtab SYMTAB 0000000000000000 154cf200
Analyzation:
if the ELF file doesn't have .symtab section, in function
|elf_functions__new, |funcs->symtab will be NULL, goto out_delete, then
run elf_functions__delete.
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/btf_encoder.c?id=06350d14776a77e16ea5064030fea63bbdd22f27#n176
And segfault happened in line: list_del(&funcs->node), since
funcs->node not added into the list elf_functions_list yet.
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/tree/btf_encoder.c?id=06350d14776a77e16ea5064030fea63bbdd22f27#n170
Should we check if the node is added into list elf_functions_list before
list_del? Please help to review this issue, thanks.
Regards
Changqing
