[PATCH] Fix pahole segfault with --show_reorg_steps option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This function call seems to mistakenly use conf directly rather than cconf
which protects against conf being null

This makes pahole segfault seemingly whenever --show_reorg_steps is used,
for example: ./pahole -R -S -C task_struct

---
 dwarves_fprintf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dwarves_fprintf.c b/dwarves_fprintf.c
index 4407fd1..1ec478c 100644
--- a/dwarves_fprintf.c
+++ b/dwarves_fprintf.c
@@ -2007,7 +2007,7 @@ next_member:

 		printed += fprintf(fp, " */\n");
 	}
- cacheline = (cconf.base_offset + type->size) % conf_fprintf__cacheline_size(conf); + cacheline = (cconf.base_offset + type->size) % conf_fprintf__cacheline_size(&cconf);
 	if (cacheline != 0)
 		printed += fprintf(fp, "%.*s/* last cacheline: %u bytes */\n",
 				   cconf.indent, tabs,
--
2.39.2





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux