On 4/9/25 8:52 AM, Ihor Solodrai wrote:
> On 4/9/25 1:59 AM, Alan Maguire wrote:
>>
>> [...]
>>
>>>> diff --git a/.github/workflows/vmtest.yml b/.github/workflows/vmtest.yml
>>>> new file mode 100644
>>>> index 0000000..0f66eed
>>>> --- /dev/null
>>>> +++ b/.github/workflows/vmtest.yml
>>>> @@ -0,0 +1,62 @@
>>>> +name: 'Build kernel run selftests via vmtest'
>>>> +
>>>> +on:
>>>> + workflow_call:
>>>> + inputs:
>>>> + runs_on:
>>>> + required: true
>>>> + default: 'ubuntu-24.04'
>>>> + type: string
>>>> + arch:
>>>> + description: 'what arch to test'
>>>> + required: true
>>>> + default: 'x86_64'
>>>> + type: string
>>>> + kernel:
>>>> + description: 'kernel version or LATEST'
>>>> + required: true
>>>> + default: 'LATEST'
>>>> + type: string
>>>> + pahole:
>>>> + description: 'pahole rev or branch'
>>>> + required: false
>>>> + default: 'master'
>>>> + type: string
>>>> + llvm-version:
>>>> + description: 'llvm version'
>>>> + required: false
>>>> + default: '18'
>>>> + type: string
>>>> +jobs:
>>>> + vmtest:
>>>> + name: pahole@${{ inputs.arch }}
>>>> + runs-on: ${{ inputs.runs_on }}
>>>> + steps:
>>>> +
>>>> + - uses: actions/checkout@v4
>>>> +
>>>> + - name: Setup environment
>>>> + uses: libbpf/ci/setup-build-env@v3
>>>> + with:
>>>> + pahole: ${{ inputs.pahole }}
>>>> + arch: ${{ inputs.arch }}
>>>> + llvm-version: ${{ inputs.llvm-version }}
>>>
>>> I think I mentioned it before, but libbpf/ci/setup-build-env checks
>>> out and installs pahole too, which is unnecessary here. Have you tried
>>> removing this step from the job?
>>>
>>> You should be able to reuse a piece of SETUP logic from
>>> build-debian.sh to install pahole's dependencies. Although you kernel
>>> build deps are needed too.
>>>
>>
>> Yeah it's the latter that are needed I think.
>>
>>> I could make a change in libbpf/ci/setup-build-env to accept a special
>>> `pahole` input value or check for env variable to NOT build pahole.
>>> What do you think?
>>
>> That would be great! Something like "pahole: none"?
>
> Yes, something like that. It's a small change. I'll let you know when
> it's done.
Hi Alan. I pushed a change to libbpf/ci today that skips pahole build
and install if 'pahole' is 'none' string. You can now use it.
>
>>
>> I'll probably try and land this more or less as-is as we're hoping to
>> get 1.30 out the door this week, but definitely will follow up with
>> builds with shared library libbpf etc. Thanks for taking a look!
>>
>> Alan
