On Sun, 2025-08-24 at 14:57 +0200, Martin Wilck wrote:
> On Thu, 2025-07-10 at 14:10 -0400, Benjamin Marzinski wrote:
> > Move logging of minor expected behavior to INFO level. Modify the
> > log
> > level of some messages by whether or not mpp->prflag changed
> > values.
> >
> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> > ---
> > libmpathpersist/mpath_persist_int.c | 26 ++++++++++++++-----------
> > -
> > 1 file changed, 14 insertions(+), 12 deletions(-)
> >
> > diff --git a/libmpathpersist/mpath_persist_int.c
> > b/libmpathpersist/mpath_persist_int.c
> > index 612bbed9..4172167a 100644
> > --- a/libmpathpersist/mpath_persist_int.c
> > +++ b/libmpathpersist/mpath_persist_int.c
> > }
> > @@ -761,22 +761,24 @@ int update_map_pr(struct multipath *mpp)
> >
> > keys.key_list[i*8], 8 , 1);
> > + if (libmp_verbosity >= 3) {
> > + condlog(3, "%s: PR IN READKEYS[%d]
> > reservation key:",
> > + mpp->alias, i);
> > + dumpHex((char *)&resp-
> > > prin_descriptor.prin_readkeys.key_list[i * 8], 8, 1);
> > + }
>
> I'd suggest to restrict usage of dumpHex() to verbosity 4 and higher.
>
> >
> > - if (!memcmp(&mpp->reservation_key, &resp-
> > > prin_descriptor.prin_readkeys.key_list[i*8], 8))
> > - {
> > - condlog(2, "%s: reservation key found in
> > pr
> > in readkeys response", mpp->alias);
> > + if (!memcmp(&mpp->reservation_key, &resp-
> > > prin_descriptor.prin_readkeys.key_list[i * 8], 8)) {
> > + condlog(3, "%s: reservation key found in
> > pr
> > in readkeys response", mpp->alias);
>
> This one should be logged at verbosity 4 only, too, IMO.
You made these changes in 03/14 of your 2nd set.
So this one is fine.
Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
Martin
