Re: [PATCH v2 1/4] block: Introduce bio_needs_zone_write_plugging()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/25/25 3:12 PM, Christoph Hellwig wrote:
> On Wed, Jun 25, 2025 at 02:59:05PM +0900, Damien Le Moal wrote:
>> +bool bio_needs_zone_write_plugging(struct bio *bio)
> 
> Can you use this in blk_zone_plug_bio instead of duplicating the logic?

I thought about doing that, but we would still need to again do the switch/case
on the bio op. But the checks before that could go into a common static helper.

> I also wonder if we should only it it, as despite looking quite complex

This does not parse...

> it should compile down to just a few instructions and is used in the
> I/O fast path.
> 
> 


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux