On Mon, May 12, 2025 at 04:05:58PM +0800, Yu Kuai wrote:
> I'm not sure, this way is simpiler, however do you prefer add structure
> and comments by following patches gradually?
In general it's easier if code that belongs together is added in
one go. Separate modules in the sense of they don't really
depend on the surroundings separately
>>> + */
>>> +struct llbitmap_barrier {
>>> + char *data;
>>
>> This is really a states array as far as I can tell. Maybe name it
>> more descriptively and throw in a comment.
>
> How about llbitmap_page_ctl ?
I mean the data pointer which really is states. No real comment
on the structure name.
