Re: [PATCH 1/2] libmutipath: handle blacklisted paths on map_discovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2025-04-28 at 17:45 -0400, Benjamin Marzinski wrote:
> If the multipath configuration is changed to blacklist existing
> devices,
> and multipathd is reloaded but the blacklisted multipaths device
> can't
> be removed, multipathd was marking the paths as INIT_PARTIAL, causing
> them to stay in the multipath device, at least until the
> partial_retrigger_delay timeout elapsed. Instead, mark them as
> INIT_REMOVED and set mpp->need_reload, so the device is reloaded and
> the
> paths are removed. To make sure the blacklisted paths are deleted
> when
> the multipath device is removed in coalesce_maps(), set their pp->mpp
> to point to map before removing it.
> 
> Fixes d9c61332 ("multipathd: trigger uevents for blacklisted paths in
> reconfigure")

The patch looks good to me, but I only vaguely understand why the bug
is introduced in d9c61332. Are you positive that before d9c61332, the
hang didn't occur?

> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux