Re: [PATCH 2/2] libdmmp/Makefile: Add target docs/man/dmmp_strerror.3 to .PHONY list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-04-04 at 14:29 +0200, Sofiane HAMAM wrote:
> From: Kéléfa Sané <kelefa.sane@xxxxxxxx>
> 
> When checking out the git repos, sometimes, target
> docs/man/dmmp_strerror.3 is newer that the prerequisite
> libdmmp/libdmmp.h this leads to a non reproducible behavior:
> Sometimes, the timestamps are updated in the manpages, sometimes not.
> 
> Signed-off-by: Yoann Congal <yoann.congal@xxxxxxxx>
> Signed-off-by: Sofiane HAMAM <sofiane.hamam@xxxxxxxx>
> Signed-off-by: Kelefa Sane <kelefa.sane@xxxxxxxx>
> ---
>  libdmmp/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> index 7e0e2509..187bcb8c 100644
> --- a/libdmmp/Makefile
> +++ b/libdmmp/Makefile
> @@ -20,7 +20,7 @@ CFLAGS += $(LIB_CFLAGS) -fvisibility=hidden
>  LIBDEPS += $(shell $(PKG_CONFIG) --libs json-c) -L$(mpathcmddir) -
> lmpathcmd -lpthread
>  
>  all: $(LIBS) doc
> -.PHONY:	doc clean install uninstall check speed_test
> dep_clean
> +.PHONY:	doc clean install uninstall check speed_test
> dep_clean docs/man/dmmp_strerror.3
>  

I've seen the issue you refer to, but this is not the right solution.
It will cause the time stamps of the man pages to be regenerated on
every build.

Martin

>  $(LIBS): $(OBJS)
>  	$(Q)$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@
> $(OBJS) $(LIBDEPS)





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux