Hi all,
Only noticed this now but for cephadm we are hardcoding the default image to be the latest version for that release.
DEFAULT_IMAGE = 'quay.io/ceph/ceph:v18'
https://github.com/ceph/ceph/blob/6b0e988052ec84cf2d4a54ff9bbbc5e720b621ad/src/cephadm/cephadm.py?plain=1#L48
Only noticed this now but for cephadm we are hardcoding the default image to be the latest version for that release.
DEFAULT_IMAGE = 'quay.io/ceph/ceph:v18'
https://github.com/ceph/ceph/blob/6b0e988052ec84cf2d4a54ff9bbbc5e720b621ad/src/cephadm/cephadm.py?plain=1#L48
Looks to be present in quincy/reef/squid
This isn't really a problem since you can specify the --image flag to be whatever you want.
Although this might be a problem for newcomers, specifying a valid release doesn't matter since it pulls the latest image for that version which can lead to some confusion.
Following the instruction on the docs: https://docs.ceph.com/en/latest/cephadm/install/#using-curl-to-install-cephadm
$ curl --silent --remote-name --location https://download.ceph.com/rpm-18.2.4/el9/noarch/cephadm
$./cephadm bootstrap --mon-ip 10.0.0.107
...
...
Pulling container image quay.io/ceph/ceph:v18...
Ceph version: ceph version 18.2.7 (6b0e988052ec84cf2d4a54ff9bbbc5e720b621ad) reef (stable)
....
Looks like there is some lore in this tracker: https://tracker.ceph.com/issues/63150 . Haven't checked the cephadm upgrade code, but not sure if it will affect that if we hard code that default_image.
Is there a reason we aren't hardcoding this default_image tag when we build the cephadm binary during the release process?
-- This isn't really a problem since you can specify the --image flag to be whatever you want.
Although this might be a problem for newcomers, specifying a valid release doesn't matter since it pulls the latest image for that version which can lead to some confusion.
Following the instruction on the docs: https://docs.ceph.com/en/latest/cephadm/install/#using-curl-to-install-cephadm
$ curl --silent --remote-name --location https://download.ceph.com/rpm-18.2.4/el9/noarch/cephadm
$./cephadm bootstrap --mon-ip 10.0.0.107
...
...
Pulling container image quay.io/ceph/ceph:v18...
Ceph version: ceph version 18.2.7 (6b0e988052ec84cf2d4a54ff9bbbc5e720b621ad) reef (stable)
....
Looks like there is some lore in this tracker: https://tracker.ceph.com/issues/63150 . Haven't checked the cephadm upgrade code, but not sure if it will affect that if we hard code that default_image.
Is there a reason we aren't hardcoding this default_image tag when we build the cephadm binary during the release process?
Joshua Blanch
Software Engineer
Clyso GmbH
p: +49 89 215252722 | a: Victoria, Canada
_______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
