On 5/20/25 10:44 AM, Alex Elder wrote: > On 5/19/25 1:38 AM, Siddarth Gundu wrote: >> strcpy() is deprecated; use strscpy() instead. >> >> Both the destination and source buffer are of fixed length >> so strscpy with 2-arguments is used. >> >> Introduce a typedef for cookie array to improve code clarity. >> >> Link: https://github.com/KSPP/linux/issues/88 >> Signed-off-by: Siddarth Gundu <siddarthsgml@xxxxxxxxx> >> --- >> changes since v1 >> - added a typedef for cookie arrays >> >> About the typedef: I was a bit hesitant to add it since the kernel >> style guide is against adding new typedef but I wanted to follow >> the review feedback for this. > > I personally think the typedef here is the appropriate. But > it's really up to Ilya whether he likes this approach. Get > his input before you do more. In any case, this should be 2 patches at that point, not collapsed into one patch. -- Jens Axboe
