On Tue, Aug 19, 2025 at 03:49:54PM +0300, Jani Nikula wrote: > On Tue, 19 Aug 2025, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > >> +EXPORT_SYMBOL_GPL(runqueues); > > > > Oh no, absolutely not. > > > > You never, ever, export a variable, and certainly not this one. > > Tangential thought: > > I think it would be possible to warn about non-function exports at build > time, and maybe plug it in W=1 builds. > Too much noise, there's a metric ton of variables exported. Sometimes its unavoidable. I just try and avoid wherever possible.
