Re: [PATCH bpf-next 2/3] selftests/bpf: skip recursive functions for kprobe_multi

[Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>]

On Mon, Aug 18, 2025 at 8:40 PM Menglong Dong <menglong8.dong@xxxxxxxxx> wrote:
>
> Some functions is recursive for the kprobe_multi and impact the benchmark
> results. So just skip them.
>
> Signed-off-by: Menglong Dong <dongml2@xxxxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/bpf/trace_helpers.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c
> index d24baf244d1f..9da9da51b132 100644
> --- a/tools/testing/selftests/bpf/trace_helpers.c
> +++ b/tools/testing/selftests/bpf/trace_helpers.c
> @@ -559,6 +559,22 @@ static bool skip_entry(char *name)
>         if (!strncmp(name, "__ftrace_invalid_address__",
>                      sizeof("__ftrace_invalid_address__") - 1))
>                 return true;
> +
> +       if (!strcmp(name, "migrate_disable"))
> +               return true;
> +       if (!strcmp(name, "migrate_enable"))
> +               return true;
> +       if (!strcmp(name, "rcu_read_unlock_strict"))
> +               return true;
> +       if (!strcmp(name, "preempt_count_add"))
> +               return true;
> +       if (!strcmp(name, "preempt_count_sub"))
> +               return true;
> +       if (!strcmp(name, "__rcu_read_lock"))
> +               return true;
> +       if (!strcmp(name, "__rcu_read_unlock"))
> +               return true;
> +

static const char *trace_blacklist[] = {
    "migrate_disable",
    "migrate_enable",
    ...
};

it's not like it's one or two functions where copy-pasting strcmp might be fine

pw-bot: cr


>         return false;
>  }
>
> --
> 2.50.1
>