> -----Original Message----- > From: Eric Dumazet <edumazet@xxxxxxxxxx> > Sent: Thursday, August 21, 2025 2:24 PM > To: Chia-Yu Chang (Nokia) <chia-yu.chang@xxxxxxxxxxxxxxxxxxx> > Cc: pabeni@xxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; corbet@xxxxxxx; horms@xxxxxxxxxx; dsahern@xxxxxxxxxx; kuniyu@xxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; dave.taht@xxxxxxxxx; jhs@xxxxxxxxxxxx; kuba@xxxxxxxxxx; stephen@xxxxxxxxxxxxxxxxxx; xiyou.wangcong@xxxxxxxxx; jiri@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; andrew+netdev@xxxxxxx; donald.hunter@xxxxxxxxx; ast@xxxxxxxxxxx; liuhangbin@xxxxxxxxx; shuah@xxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; ij@xxxxxxxxxx; ncardwell@xxxxxxxxxx; Koen De Schepper (Nokia) <koen.de_schepper@xxxxxxxxxxxxxxxxxxx>; g.white@xxxxxxxxxxxxx; ingemar.s.johansson@xxxxxxxxxxxx; mirja.kuehlewind@xxxxxxxxxxxx; cheshire@xxxxxxxxx; rs.ietf@xxxxxx; Jason_Livingood@xxxxxxxxxxx; vidhi_goel@xxxxxxxxx > Subject: Re: [PATCH v15 net-next 08/14] tcp: accecn: AccECN needs to know delivered bytes > > > CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information. > > > > On Fri, Aug 15, 2025 at 1:39 AM <chia-yu.chang@xxxxxxxxxxxxxxxxxxx> wrote: > > > > From: Ilpo Järvinen <ij@xxxxxxxxxx> > > > > AccECN byte counter estimation requires delivered bytes which can be > > calculated while processing SACK blocks and cumulative ACK. The > > delivered bytes will be used to estimate the byte counters between > > AccECN option (on ACKs w/o the option). > > > > Non-SACK calculation is quite annoying, inaccurate, and likely bogus. > > Does it mean AccECN depends on SACK ? > In fact, AccECN does not depend on SACK to function; however, it would be more accurate if SACK were there. In order to avoid confusion, I will remove this old comment in the next version. Chia-Yu
