Re: [PATCH v3 bpf-next] bpf: improve the general precision of tnum_mul
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 bpf-next] bpf: improve the general precision of tnum_mul
- From: Nandakumar Edamana <nandakumar@xxxxxxxxxxxxxxxx>
- Date: Fri, 22 Aug 2025 07:41:14 +0530
- Cc: Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>
- In-reply-to: <20250822014754.1962075-1-nandakumar@nandakumar.co.in>
- User-agent: Mozilla Thunderbird
I've checked the three new test programs on an old kernel that has the
current tnum_mul and a newly built one that has the proposed tnum_mul.
verifier_mul/mul_precise results in a false positive with the current
tnum_mul, while the program passes with the new build. While it is
unfair to compare two kernel versions, logs indicated this is indeed a
multiplication-related issue.
Honestly, with some effort, creating examples where the new tnum_mul
causes issues with its imprecision should also be possible; but as as
Eduard suggested, this was added "just to have selftests that can detect
the change."
---
Nandakumar
[Index of Archives]
[Linux Samsung SoC]
[Linux Rockchip SoC]
[Linux Actions SoC]
[Linux for Synopsys ARC Processors]
[Linux NFS]
[Linux NILFS]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Yosemite News]
[Linux Kernel]
[Linux SCSI]