On Fri, Aug 29, 2025 at 12:56 PM Barry Song <21cnbao@xxxxxxxxx> wrote: > > On Tue, Aug 26, 2025 at 3:43 PM Yafang Shao <laoar.shao@xxxxxxxxx> wrote: > [...] > > > @@ -4510,13 +4510,18 @@ static struct folio *alloc_swap_folio(struct vm_fault *vmf) > > if (!zswap_never_enabled()) > > goto fallback; > > > > + suggested_orders = get_suggested_order(vma->vm_mm, vma, vma->vm_flags, > > + TVA_PAGEFAULT, > > + BIT(PMD_ORDER) - 1); > > Can we separate this case from the normal anonymous page faults below? > We’ve observed that swapping in large folios can lead to more > swap thrashing for some workloads- e.g. kernel build. Consequently, > some workloads > might prefer swapping in smaller folios than those allocated by > alloc_anon_folio(). make sense to me. Perhaps we can add a new tva_type such as TVA_SWAP for this case. -- Regards Yafang
