On Thu, 28 Aug 2025 at 20:48, Ricardo B. Marlière <rbm@xxxxxxxx> wrote: > > Currently, even if some subtests fails, the end result will still yield > "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are > any failures. > > Signed-off-by: Ricardo B. Marlière <rbm@xxxxxxxx> Thanks Ricardo. Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > --- > tools/testing/selftests/bpf/test_xsk.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh > index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755 > --- a/tools/testing/selftests/bpf/test_xsk.sh > +++ b/tools/testing/selftests/bpf/test_xsk.sh > @@ -241,4 +241,6 @@ done > > if [ $failures -eq 0 ]; then > echo "All tests successful!" > +else > + exit 1 > fi > > --- > base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322 > change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071 > > Best regards, > -- > Ricardo B. Marlière <rbm@xxxxxxxx> > >
