On Thu, Sep 4, 2025 at 9:51 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote: > > On Wed, Sep 3, 2025 at 10:58 PM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > > > Hi, Hengqi, > > > > On Wed, Sep 3, 2025 at 8:05 PM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote: > > > > > > The bpf_flush_icache() is called by bpf_arch_text_copy() > > > already. So remove it. > > > > > > Signed-off-by: Hengqi Chen <hengqi.chen@xxxxxxxxx> > > > --- > > > arch/loongarch/net/bpf_jit.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/loongarch/net/bpf_jit.c b/arch/loongarch/net/bpf_jit.c > > > index 77033947f1b2..9155f9e725a1 100644 > > > --- a/arch/loongarch/net/bpf_jit.c > > > +++ b/arch/loongarch/net/bpf_jit.c > > > @@ -1721,7 +1721,6 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *ro_image, > > > goto out; > > > } > > > > > > - bpf_flush_icache(ro_image, ro_image_end); > > Both ARM64 and RISC-V do this, so I prefer to keep it. > > > > Then they probably should remove it too, I guess. I think we should understand why they do so first. Huacai > > > Huacai > > > > > out: > > > kvfree(image); > > > return ret < 0 ? ret : size; > > > -- > > > 2.43.5 > > >
