On Mon, Sep 8, 2025 at 12:27 PM Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote: > > On 9/5/25 10:33 AM, Amery Hung wrote: > > An unused argument, flags is reserved for future extension (e.g., > > tossing the data instead of copying it to the linear data area). > > > +__bpf_kfunc int bpf_xdp_pull_data(struct xdp_md *x, u32 len, u64 flags) > > I was thinking the flag may be needed to avoid copy. I think we have recently > concluded that bpf_xdp_adjust_head can support shrink on multi buf also. If it > is the case, it is probably better to keep a similar api as the > bpf_skb_pull_data which does not have the flags argument. > Make sense. I will remove flags.
