On Wed, Sep 10, 2025 at 04:42:18PM +0200, Gatien CHEVALLIER wrote: > > > On 9/9/25 18:48, Russell King (Oracle) wrote: > > In preparation to cleaning up the (re-)initialisation of timestamping, > > rename the existing stmmac_init_ptp() to stmmac_init_timestamping() > > which better reflects its functionality. > > > > I agree it's mostly about time stamping but if the ptp_clk_freq_config() > ops is implemented, then it's not only about timestamping. Wasn't it > fine as is? No, if you look at the history, various bits of PTP initialisation have had to be moved out of stmmac_init_ptp() due to various problems, and this includes initialisation of the TAI timekeeping block block (or what we call ptp_clock in the kernel.) It's become less about initialising the entire PTP subsystem, more about just the time- stamping part. So, the rename is justified, even though there's still bits in there that need to be re-architected. However, continuing to call it "init_ptp" when it doesn't initialise all of PTP, especially as the patches after this adds another function that _does_ to the full initialisation just doesn't make sense - in fact, it becomes down-right confusing. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
