On Tue, 9 Sep 2025 15:30:00 +0200 Jesper Dangaard Brouer wrote: > I'm fine with the name xdp_update_skb_frags_info(). > But I want to point out that the function *does* also update shinfo. > The xdp_buff/xdp-frame have a compatible layout for shinfo, except for a > union with sinfo->destructor_arg, which we need to clear. This is a > transition point from XDP to SKB, which is why I think the function name > change is appropiate. Fair point. My initial confusion was because I expected xdp_update_skb_shared_info() to _only_ update shinfo. > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > --- > > v1: > > - rename skb_flags arg to xdp_flags > > Thanks for that. You kept the function name xdp_buff_get_skb_flags(), > indicating this is "skb_flags". I don't think it matters much, so to > avoid bikesheeting I'm just going to ACK this. Thanks! Happy to respin with whatever names, if anyone expresses a strong opinion. Otherwise I'll fix the typo and apply tomorrow. Indeed the risk of bikeshedding is rather high here :)
