Re: [PATCH v3 00/15] Legacy hardware/cache events as json

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 28/08/2025 9:59 pm, Ian Rogers wrote:
Mirroring similar work for software events in commit 6e9fa4131abb
("perf parse-events: Remove non-json software events"). These changes
migrate the legacy hardware and cache events to json.  With no hard
coded legacy hardware or cache events the wild card, case
insensitivity, etc. is consistent for events. This does, however, mean
events like cycles will wild card against all PMUs. A change doing the
same was originally posted and merged from:
https://lore.kernel.org/r/20240416061533.921723-10-irogers@xxxxxxxxxx
and reverted by Linus in commit 4f1b067359ac ("Revert "perf
parse-events: Prefer sysfs/JSON hardware events over legacy"") due to
his dislike for the cycles behavior on ARM with perf record. Earlier
patches in this series make perf record event opening failures
non-fatal and hide the cycles event's failure to open on ARM in perf
record, so it is expected the behavior will now be transparent in perf
record on ARM. perf stat with a cycles event will wildcard open the
event on all PMUs.

Hi Ian,

Briefly testing perf record and perf stat seem to work now. i.e "perf record -e cycles" doesn't fail and just skips the uncore cycles event. And "perf stat" now includes the uncore cycles event which I think is harmless.

But there are a few perf test failures. For example "test event parsing":

  evlist after sorting/fixing: 'arm_cmn_0/cycles/,{cycles,cache-
    misses,branch-misses}'
  FAILED tests/parse-events.c:1589 wrong number of entries
  Event test failure: test 57 '{cycles,cache-misses,branch-
    misses}:e'running test 58 'cycles/name=name/'

The tests "Perf time to TSC" and "Use a dummy software event to keep tracking" are using libperf to open the cycles event as a sampling event which now fails. It seems like we've fixed Perf record to ignore this failure, but we didn't think about libperf until now.

Thanks
James





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux