Jakub Kicinski <kuba@xxxxxxxxxx> writes: > xdp_update_skb_shared_info() needs to update skb state which > was maintained in xdp_buff / frame. Pass full flags into it, > instead of breaking it out bit by bit. We will need to add > a bit for unreadable frags (even tho XDP doesn't support > those the driver paths may be common), at which point almost > all call sites would become: > > xdp_update_skb_shared_info(skb, num_frags, > sinfo->xdp_frags_size, > MY_PAGE_SIZE * num_frags, > xdp_buff_is_frag_pfmemalloc(xdp), > xdp_buff_is_frag_unreadable(xdp)); > > Keep a helper for accessing the flags, in case we need to > transform them somehow in the future (e.g. to cover up xdp_buff > vs xdp_frame differences). > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > --- > Does anyone prefer the current form of the API, or can we change > as prosposed? I think the change is fine, but I agree with Jesper that it's a bit weird to call them skb_flags. Maybe just xdp_buff_get_flags()? -Toke
