Re: [PATCH 0/2] riscv, bpf: fix reads of thread_info.cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Radim,

On 8/12/25 11:02, Radim Krčmář wrote:
Hello,

These patches are related to a recently queued series [1] that fixes the
same bugs in normal code.  That series finishes with a patch that would
have exposed the BPF bugs, but luckily it won't get merged until v6.18.

I don't know enough about BPF to verify that it emits the correct code
now, so any pointers are welcome.

1: https://lore.kernel.org/linux-riscv/20250725165410.2896641-3-rkrcmar@xxxxxxxxxxxxxxxx/

Radim Krčmář (2):
   riscv, bpf: use lw when reading int cpu in BPF_MOV64_PERCPU_REG
   riscv, bpf: use lw when reading int cpu in bpf_get_smp_processor_id

  arch/riscv/net/bpf_jit_comp64.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Both patches look good so:

Reviewed-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>

Since this only touches riscv and I have a bunch of fixes pending, I propose to take those patches through the riscv tree, I'll just wait for Björn to confirm it is correct.

@Radim: This is the third similar bug, did you check all assembly code (and bpf) to make sure we don't have anymore left or should I?

Thanks,

Alex





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux