On Fri, Jul 25, 2025 at 04:11:27PM -0700, Yonghong Song wrote: > > Okay, looks like Peter has made similar changes before. > See https://lore.kernel.org/all/20231215092707.799451071@xxxxxxxxxxxxx/ > > To be consistent with existing code base, I think the following > change is better: > > diff --git a/kernel/bpf/crypto.c b/kernel/bpf/crypto.c > index 94854cd9c4cc..a267d9087d40 100644 > --- a/kernel/bpf/crypto.c > +++ b/kernel/bpf/crypto.c > @@ -261,6 +261,12 @@ __bpf_kfunc void bpf_crypto_ctx_release(struct bpf_crypto_ctx *ctx) > call_rcu(&ctx->rcu, crypto_free_cb); > } > +__bpf_kfunc void bpf_crypto_ctx_release_dtor(void *ctx) > +{ > + bpf_crypto_ctx_release(ctx); > +} > +CFI_NOSEAL(bpf_crypto_ctx_release_dtor); > + > static int bpf_crypto_crypt(const struct bpf_crypto_ctx *ctx, > const struct bpf_dynptr_kern *src, > const struct bpf_dynptr_kern *dst, > @@ -368,7 +374,7 @@ static const struct btf_kfunc_id_set crypt_kfunc_set = { > BTF_ID_LIST(bpf_crypto_dtor_ids) > BTF_ID(struct, bpf_crypto_ctx) > -BTF_ID(func, bpf_crypto_ctx_release) > +BTF_ID(func, bpf_crypto_ctx_release_dtor) > static int __init crypto_kfunc_init(void) > { > > The same code pattern can be done for patch 2 and patch 3. Sure, I'll update the patches and send v3. Sami
