2025-07-23 11:40 UTC+0100 ~ Quentin Monnet <qmo@xxxxxxxxxx>
> 2025-07-23 11:31 UTC+0800 ~ Tao Chen <chen.dylane@xxxxxxxxx>
>> Add `bpftool token show` command to get token info
>> from bpffs in /proc/mounts.
>>
>> Example plain output for `token show`:
>> token_info /sys/fs/bpf/token
>> allowed_cmds:
>> map_create prog_load
>> allowed_maps:
>> allowed_progs:
>> kprobe
>> allowed_attachs:
>> xdp
>> token_info /sys/fs/bpf/token2
>> allowed_cmds:
>> map_create prog_load
>> allowed_maps:
>> allowed_progs:
>> kprobe
>> allowed_attachs:
>> xdp
>>
>> Example json output for `token show`:
>> [{
>> "token_info": "/sys/fs/bpf/token",
>> "allowed_cmds": ["map_create", "prog_load"],
>> "allowed_maps": [],
>> "allowed_progs": ["kprobe"],
>> "allowed_attachs": ["xdp"]
>> }, {
>> "token_info": "/sys/fs/bpf/token2",
>> "allowed_cmds": ["map_create", "prog_load"],
>> "allowed_maps": [],
>> "allowed_progs": ["kprobe"],
>> "allowed_attachs": ["xdp"]
>> }]
>>
>> Signed-off-by: Tao Chen <chen.dylane@xxxxxxxxx>
>> ---
>
> [...]
>
>> diff --git a/tools/bpf/bpftool/token.c b/tools/bpf/bpftool/token.c
>> new file mode 100644
>> index 00000000000..06b56ea40b8
>> --- /dev/null
>> +++ b/tools/bpf/bpftool/token.c
>
> [...]
>
>> +static int do_help(int argc, char **argv)
>> +{
>> + if (json_output) {
>> + jsonw_null(json_wtr);
>> + return 0;
>> + }
>> +
>> + fprintf(stderr,
>> + "Usage: %1$s %2$s { show | list }\n"
>> + " %1$s %2$s help\n"
>
>
> One more nit: applying and testing the help message locally, I noticed
> that the alignement is not correct:
>
> $ ./bpftool token help
> Usage: bpftool token { show | list }
> bpftool token help
>
> The two "bpftool" should be aligned. This is because you use a tab for
> indent on the "help" line. Can you please replace it with spaces to fix
> indentation, and remain consistent with what other files do?
>
> After that change, you can add:
>
> Reviewed-by: Quentin Monnet <qmo@xxxxxxxxxx>
>
Please also take a look at the "CHECK" reports from checkpatch, some of
them are worth addressing:
https://netdev.bots.linux.dev/static/nipa/984952/14165722/checkpatch/stdout
(accessed via
https://patchwork.kernel.org/project/netdevbpf/patch/20250723033107.1411154-1-chen.dylane@xxxxxxxxx/)
Thanks,
Quentin
