On Mon, Jul 14, 2025 at 02:03:48PM -0700, Mohsin Bashir wrote:
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
>
> Add basic XDP support by hooking in do_xdp_generic().
> This should be enough to validate most basic XDP tests.
>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@xxxxxxxxx>
> ---
> drivers/net/netdevsim/netdev.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
> index f316e44130f7..ab2cdbf968a7 100644
> --- a/drivers/net/netdevsim/netdev.c
> +++ b/drivers/net/netdevsim/netdev.c
> @@ -332,15 +332,32 @@ static int nsim_get_iflink(const struct net_device *dev)
> static int nsim_rcv(struct nsim_rq *rq, int budget)
> {
> struct net_device *dev = rq->napi.dev;
> + struct bpf_prog *xdp_prog;
> + struct netdevsim *ns;
> struct sk_buff *skb;
> unsigned int skblen;
> int i, ret;
>
> + ns = netdev_priv(dev);
> + xdp_prog = rcu_dereference(ns->xdp.prog);
I'm somewhat confused by this because ns->xdp.prog doesn't appear to be
protected by RCU.
Flagged by Sparse.
--
pw-bot: changes-requested
