Re: [PATCH v12 net-next 07/15] tcp: Add wait_third_ack for ECN negotiation in simultaneous connect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/4/25 10:53 AM, chia-yu.chang@xxxxxxxxxxxxxxxxxxx wrote:
> From: Chia-Yu Chang <chia-yu.chang@xxxxxxxxxxxxxxxxxxx>
> 
> In simultaneous connect scenario, the connection will be established
> when SYN/ACK is received after patch 23e89e8ee7be7. However, the
> third ACK is still anticipated to complete the negotiation for either
> RFC3168 ECN and Accurate ECN. In this sense, an additional flag
> wait_third_ack is introduced to identify that the 3rd ACK is still
> anticipated to ensure ECN or AccECN negotiation will be done in the
> ESTABLISHED state.
> 
> Signed-off-by: Chia-Yu Chang <chia-yu.chang@xxxxxxxxxxxxxxxxxxx>
> Co-developed-by: Ilpo Järvinen <ij@xxxxxxxxxx>
> Signed-off-by: Ilpo Järvinen <ij@xxxxxxxxxx>

I saw there are existing pktdrill test for ECN with simultaneous
connect, but I'm still wondering it there is a real use case behind?

AFAICS simult connect can happen only on loopback, and [Acc]ECN on
loopback looks useless.

I would simply not allow AccECN on simultaneous connect - assuming that
would basically drop all the code in this patch without no fourther
modification required.

/P





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux