On Sun, Jul 13, 2025 at 3:58 PM Sam James <sam@xxxxxxxxxx> wrote: > > Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> writes: > > > On Sat, Jul 12, 2025 at 11:24 PM Sam James <sam@xxxxxxxxxx> wrote: > >> > >> Daniel Borkmann <daniel@xxxxxxxxxxxxx> writes: > >> > >> > On 7/5/25 12:43 PM, Sam James wrote: > >> >> Check the 'WERROR' variable and suppress adding '-Werror' if WERROR=0. > >> >> This mirrors what tools/perf and other directories in tools do to > >> >> handle > >> >> -Werror rather than adding it unconditionally. > >> > > >> > Could you also add to the commit desc why you need it? Are there particular > >> > warnings you specifically need to suppress when building under gentoo? > >> > >> Sure. In this case, it was https://bugs.gentoo.org/959293 where I think > > > > I don't recall it was reported on bpf mailing list. > > > >> it's fixed by > >> https://github.com/libbpf/libbpf/commit/715808d3e2d8c54f3001ce3d7fcda0844f765969 > > > > and looks like it was fixed by accident, so.. > > I'll note that I've sent patches that have been merged for these > before. It's just that they're sensitive to optimisation level and prone > to false positives. Especially with e.g. -Og. Yeah. Compilers do produce false positives and, like any tool, any warning is not authoritative, but we prefer people reporting them instead of silencing and moving on.
