Quentin Monnet <qmo@xxxxxxxxxx> writes: > 2025-07-07 15:18 UTC+0200 ~ Daniel Borkmann <daniel@xxxxxxxxxxxxx> >> On 7/5/25 12:43 PM, Sam James wrote: >>> Check the 'WERROR' variable and suppress adding '-Werror' if WERROR=0. >>> >>> This mirrors what tools/perf and other directories in tools do to handle >>> -Werror rather than adding it unconditionally. >> >> Could you also add to the commit desc why you need it? Are there particular >> warnings you specifically need to suppress when building under gentoo? > > > And if you need to disable the flag on a particular target, have you > considered using the existing variables and pass EXTRA_CFLAGS=-Wno-error > rather than adding another flag? I think inconsistency with other tools/ is unfortunate, but yes, I guess we could. > > Quentin